Add select-mode, version, and publish sub-actions#656
Conversation
🦋 Changeset detectedLatest commit: 10ef577 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| pr-branch: | ||
| description: "Sets the branch in which the action will run. Defaults to `github.ref_name`." |
There was a problem hiding this comment.
Unrelated to this PR - but it seems to me this is a somewhat broken/weird input. It only kinda sets the base branch to pr-branch (so maybe this should be called base-branch?) but without actually even checking out this base. So dunno, maybe it kinda works OK for workflows that checkout another base beforehand but we don't make any guarantees here about the outcomes to be particularly coherent.
There was a problem hiding this comment.
Ah yeah it should be base-branch. I only read the top of the code and though this was the name of the branch for the PR.
There was a problem hiding this comment.
Actually yeah it is kinda weird. Maybe pr-base-branch would be better here? Because we're only using it for the PR's base
There was a problem hiding this comment.
Yeah, I think pr-base-branch would be better. It is kinda weird-ish that it's not like auto-synced with the actual local checkout and the user intention... but the use case of running a workflow from A (when we infer the pr base branch from the payload), and then targeting B with PRs (and maybe checking out B in the workflow too) is not really standard. So I don't think any changes to our default behavior should be made
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Andarist
force-pushed
the
new-version-publish-subaction
branch
from
b6da0bd to
10ef577
Compare
2 participants
Adds a very simple implementation of
/select-mode,/version, and/publishsub-actions that reuses functions from the root action. I renamed some of the inputs, copied most of the logic over. There's probably more cleanup possible but I don't want to stray too far for now.I also did not write any readme/docs as
I'm lazymaybe it changes after the publish-plan PRs.I made this PR mainly so we can make updates on it easier later, but I'm also fine closing this as starting from scratch with the publish-plan stuff if that's easier.